Re: [Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

[Peter Maydell]

On 31 August 2017 at 15:04, Kamil Rytarowski <address@hidden> wrote:
> Could we please add SmartOS image. It's an Illumos distribution,
> previously known as OpenSolaris.
>
> qemu is actively maintained for SmartOS in pkgsrc.
>
> The latest build fixes were introduced less than a week ago.
> https://github.com/NetBSD/pkgsrc/commit/f2608af5433f1491a92567bf570e9349dffbda7a

Maintaining out of tree patches without posting them upstream
is rather counterproductive, because if the host OS doesn't
build or have anybody submitting patches to fix it upstream
we will conclude that it's unused and delete the support entirely.
That E1000_SEC define has been around for nearly 10 years
without anybody saying it was a problem, for instance.
(Indeed Solaris is probably next after AIX on the "nobody
came along to tell us they cared enough to help us maintain
it" list for removal as a result.)

> I'm going to submit the SmartOS patches to fix the build
> regardless of the decision.

Thank you. Do you also have some instructions on how to
get it running in a VM or something so we can add it to
our build tests? (Login on a build machine, or a SmartOS
host in the gcc compile farm, would work too).

thanks
-- PMM