[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-vi
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h |
Date: |
Thu, 31 Aug 2017 15:18:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 31.08.2017 11:29, Thomas Huth wrote:
> On 30.08.2017 19:05, David Hildenbrand wrote:
>> The only interface left, so let's properly rename it.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>> hw/s390x/s390-virtio-ccw.c | 2 +-
>> hw/s390x/s390-virtio-hcall.c | 2 +-
>> hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>> rename hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} (92%)
> [...]
>> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio-hcall.h
>> similarity index 92%
>> rename from hw/s390x/s390-virtio.h
>> rename to hw/s390x/s390-virtio-hcall.h
>> index d984cd4115..64c5bbd827 100644
>> --- a/hw/s390x/s390-virtio.h
>> +++ b/hw/s390x/s390-virtio-hcall.h
>> @@ -1,5 +1,5 @@
>> /*
>> - * Virtio interfaces for s390
>> + * Support for virtio hypercalls on s390x
>> *
>> * Copyright 2012 IBM Corp.
>> * Author(s): Cornelia Huck <address@hidden>
>>
>
> Maybe also rename the HW_S390_VIRTIO_H header guard? Anyway:
>
> Reviewed-by: Thomas Huth <address@hidden>
>
Sure, will do. Is HW_S390_VIRTIO_HCALL_H okay?
(HW_S390X_S390_VIRTIO_HCALL_H doesn't sound necessary)
--
Thanks,
David
[Qemu-devel] [PATCH v1 07/11] target/s390x: rename next_cpu_id to next_cpu_addr, David Hildenbrand, 2017/08/30
[Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG, David Hildenbrand, 2017/08/30