[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3 |
Date: |
Wed, 30 Aug 2017 18:15:02 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Sat, Aug 19, 2017 at 10:58:44PM -0700, David Michael wrote:
> This allows building with "./configure --python=python3", where
> the python3 program is at least version 3.6. It preserves
> compatibility with Python 2. The changes include:
>
> - Avoiding "print" usage
> - Using bytes with files opened in binary mode
> - Switching .iteritems() to .items()
> - Adding fallback imports for functions moved to other modules
>
> Signed-off-by: David Michael <address@hidden>
> ---
>
> Hi,
>
> I've been applying these changes when building on Fedora 26, which does
> not include any Python 2 packages by default. It was tested with Python
> 2.7 and 3.6.
>
> I just saw the list of scripts that need updating on the mailing list,
> and this doesn't cover all of them, but it is enough to build a binary
> for running virtual machines with KVM. Maybe it is still useful as a
> starting point.
>
> Thanks.
>
> David
>
> configure | 6 ++++--
> scripts/qapi.py | 31 ++++++++++++++++++++-----------
> scripts/qapi2texi.py | 10 +++++-----
> scripts/signrom.py | 4 ++--
> 4 files changed, 31 insertions(+), 20 deletions(-)
Cool, thanks for contributing this!
Reviewed-by: Stefan Hajnoczi <address@hidden>
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, (continued)
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, Peter Maydell, 2017/08/31
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, Markus Armbruster, 2017/08/31
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, Daniel P. Berrange, 2017/08/31
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, Peter Maydell, 2017/08/31
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, Daniel P. Berrange, 2017/08/31
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, Peter Maydell, 2017/08/31
- Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3, Peter Maydell, 2017/08/31
Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3,
Stefan Hajnoczi <=