[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb |
Date: |
Wed, 30 Aug 2017 17:01:26 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, Aug 21, 2017 at 03:49:05PM +0200, Gerd Hoffmann wrote:
> On Thu, 2017-08-10 at 16:55 +0100, Daniel P. Berrange wrote:
> > - virtio_input_key_config(vinput, keymap_qcode,
> > - ARRAY_SIZE(keymap_qcode));
> > + virtio_input_key_config(vinput, qemu_input_map_qcode2linux,
> > + qemu_input_map_qcode2linux_len);
>
> That is a guest-visible change.
Huh, really ?!?!?
Are you saying the guest OS sees the raw qcode values ? IIUC these are
something we never wanted to expose outside QEMU, because nothing in
QAPI is gauranteeing enum values are stable - only the string
representation is stable in QAPI.
I thought this device was sending linux keycodes to the guest, not
qcodes ????
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH 01/15] ui: add keycodemapdb repository as a GIT submodule, (continued)
- [Qemu-devel] [PATCH 02/15] ui: convert common input code to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 03/15] ui: convert key events to QKeyCodes immediately, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 04/15] ui: don't export qemu_input_event_new_key, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 05/15] ui: use QKeyCode exclusively in InputKeyEvent, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 09/15] char: convert the escc device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 07/15] input: convert ps2 device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 08/15] input: convert the adb device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 10/15] ui: convert cocoa frontend to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 11/15] ui: convert the SDL2 frontend to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 12/15] ui: convert GTK and SDL1 frontends to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 13/15] ui: remove qemu_input_qcode_to_number method, Daniel P. Berrange, 2017/08/10