[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared
|
From: |
Kashyap Chamarthy |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194) |
|
Date: |
Wed, 30 Aug 2017 11:05:08 +0200 |
|
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Tue, Aug 29, 2017 at 04:16:54PM -0500, Eric Blake wrote:
> On 08/29/2017 12:42 PM, Stefan Hajnoczi wrote:
> > On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy <address@hidden> wrote:
> >> This is the follow-up patch that was discussed[*] as part of feedback to
> >> qemu-iotest 194.
> >>
>
> >> Signed-off-by: Kashyap Chamarthy <address@hidden>
> >> ---
> >> Changes in v3:
> >> - Wait for migration to complete before issuing `block-job-cancel`
> >> (StefanH)
> >> - Wait for the event BLOCK_JOB_COMPLETED on the source before stopping
> >> the NBD server on the destination (StefanH)
> >>
> >> Changes in v2:
> >> - Check for both the events: MIGRATION and BLOCK_JOB_COMPLETED (EricB)
> >> ---
> >> tests/qemu-iotests/194 | 23 +++++++++++++++++------
> >> tests/qemu-iotests/194.out | 11 ++++++++---
> >> 2 files changed, 25 insertions(+), 9 deletions(-)
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
>
> Thanks; I've added this to my NBD queue (pull request to come shortly
> after 2.11 release is finalized), since the test uses NBD.
Sure, thanks for the quick reviews, both!
--
/kashyap