Re: [Qemu-devel] [PULL 0/1] slirp updates

[Peter Maydell]

On 29 August 2017 at 10:22, Samuel Thibault <address@hidden> wrote:
> Peter Maydell, on mar. 29 août 2017 10:20:31 +0100, wrote:
>> On 28 August 2017 at 00:05, Samuel Thibault
>> <address@hidden> wrote:
>> > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
>> > The following changes since commit 
>> > 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>> >
>> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 
>> > +0200)
>> >
>> > are available in the git repository at:
>> >
>> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>> >
>> > for you to fetch changes up to 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>> >
>> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 
>> > +0200)
>> >
>> > ----------------------------------------------------------------
>> > slirp updates
>> >
>> > ----------------------------------------------------------------
>>
>> Is this pull request intended to be for 2.10 (in which
>> case it needs justification) or for 2.11 (in which case
>> it's a bit early) ?
>
> It is for 2.10. It fixes at least a DOS: userland can at least crash
> qemu with specially-crafted packets.

It's really really hard to justify putting this in now.
If it had come in last Wednesday it would have been
easy to put into rc4. If it had come in next Thursday
we'd have shrugged and said "ok, needs to go into next
stable release". Right now it's a choice of "treat it
as if it had arrived in two days time" (ie don't put it
in 2.10) or delay the release by yet another rc cycle.

thanks
-- PMM