[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] qlit: replace assert(qnum_get_try_int)
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 09/14] qlit: replace assert(qnum_get_try_int) |
Date: |
Fri, 25 Aug 2017 09:02:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> qnum_get_int() will assert if underlying type isn't compatible.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> qobject/qlit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qobject/qlit.c b/qobject/qlit.c
> index 07ad6b05e8..7e4bf92862 100644
> --- a/qobject/qlit.c
> +++ b/qobject/qlit.c
> @@ -53,7 +53,7 @@ bool qlit_equal_qobject(const QLitObject *lhs, const
> QObject *rhs)
> case QTYPE_QBOOL:
> return lhs->value.qbool == qbool_get_bool(qobject_to_qbool(rhs));
> case QTYPE_QNUM:
> - g_assert(qnum_get_try_int(qobject_to_qnum(rhs), &val));
> + val = qnum_get_int(qobject_to_qnum(rhs));
> return lhs->value.qnum == val;
> case QTYPE_QSTRING:
> return (strcmp(lhs->value.qstr,
Suggest commit message
qlit: Replace open-coded qnum_get_int() by call
Bonus: rids us of a side effect in an assertion.
Can do on commit.
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj, (continued)
- [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 06/14] qlit: make qlit_equal_qobject return a bool, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 08/14] qlit: add QLIT_QNULL and QLIT_BOOL, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 09/14] qlit: replace assert(qnum_get_try_int), Marc-André Lureau, 2017/08/24
- Re: [Qemu-devel] [PATCH 09/14] qlit: replace assert(qnum_get_try_int),
Markus Armbruster <=
- [Qemu-devel] [PATCH 11/14] qlit: improve QLit dict vs qdict comparison, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 10/14] tests: add qlit tests, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 12/14] qlit: improve QLit list vs qlist comparison, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 13/14] qlit: add qobject_form_qlit(), Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 14/14] qapi: generate a literal qobject for introspection, Marc-André Lureau, 2017/08/24