qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/54] qdict: add qdict_put_null() helper


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 02/54] qdict: add qdict_put_null() helper
Date: Tue, 22 Aug 2017 17:09:47 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Marc-André Lureau <address@hidden> writes:

> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  include/qapi/qmp/qdict.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
> index 363e431106..a35bed9f16 100644
> --- a/include/qapi/qmp/qdict.h
> +++ b/include/qapi/qmp/qdict.h
> @@ -60,6 +60,8 @@ void qdict_destroy_obj(QObject *obj);
   /* Helpers for int, bool, and string */
   #define qdict_put_int(qdict, key, value) \
           qdict_put(qdict, key, qnum_from_int(value))
   #define qdict_put_bool(qdict, key, value) \
>          qdict_put(qdict, key, qbool_from_bool(value))
>  #define qdict_put_str(qdict, key, value) \
>          qdict_put(qdict, key, qstring_from_str(value))
> +#define qdict_put_null(qdict, key) \
> +        qdict_put(qdict, key, qnull())
>  
>  /* High level helpers */
>  double qdict_get_double(const QDict *qdict, const char *key);

Marginal.  I can accept it for completeness's sake, or rather a step
towards completeness.  But please update the "Helpers for ..." comment,
and convert existing qdict_put(QD, K, qnull()) to use qdict_put_null().
A quick grep finds some in target/i386/cpu.c.  There might be more.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]