|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH] nbd-client: avoid spurious qio_channel_yield() re-entry |
Date: | Tue, 22 Aug 2017 15:23:32 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 22/08/2017 14:51, Stefan Hajnoczi wrote: > This should fix the issue that Dave is seeing but I'm concerned that > there are more problems in nbd-client.c. We don't have good > abstractions for writing coroutine socket I/O code. Something like Go's > channels would avoid manual low-level coroutine calls. There is > currently no way to cancel qio_channel_yield() so requests doing I/O may > remain in-flight indefinitely and nbd-client.c doesn't join them... The idea was that shutdown(2) would force them to reenter... Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |