Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

[Igor Mammedov]

On Fri, 18 Aug 2017 17:08:29 -0300
Philippe Mathieu-Daudé <address@hidden> wrote:

> On 08/17/2017 12:22 PM, Igor Mammedov wrote:
> > On Thu, 17 Aug 2017 01:30:54 -0300
> > Philippe Mathieu-Daudé <address@hidden> wrote:  
> [...]
> >> Also I couldn't test it with KVM.  
> > Tested in TCG mode (boots debian mips/mips64 kernel with different cpu 
> > types),
> > and new CPU leaf types show up on QOM tree as expected (QOMifycation is 
> > done as expected)  
> 
> you mean the "info qom-tree" output?
I've used scripts/qmp/qom-* scripts for testing which use QMP,
but QOM tree that both use is the same so there shouldn't be any difference.


> 
> > and '-cpu help' also works as expected,
> > so with checkpatch issues fixed you may add to patches my
> > 
> > Tested-by: Igor Mammedov <address@hidden>  
> 
> ok thanks for the testing!
> 
> I'll wait to see if there is some KVM feedback from imgtec folks before 
> spaming a v2.
> 
> >> Igor Mammedov (2):
> >>    mips: MIPSCPU model subclasses
> >>    mips: replace cpu_mips_init() with cpu_generic_init()
> >>
> >> Philippe Mathieu-Daudé (6):
> >>    mips: move hw/mips/cputimer.c to target/mips/
> >>    mips: introduce internal.h and cleanup cpu.h
> >>    mips: split cpu_mips_realize_env() out of cpu_mips_init()
> >>    mips: call cpu_mips_realize_env() from mips_cpu_realizefn()
> >>    mips: now than MIPSCPU is QOMified, mark it abstract
> >>    mips: update mips_cpu_list() to use object_class_get_list()
> >>
> >>   target/mips/cpu-qom.h                         |   1 +
> >>   target/mips/cpu.h                             | 357 
> >> +---------------------
> >>   target/mips/internal.h                        | 422 
> >> ++++++++++++++++++++++++++
> >>   hw/mips/cps.c                                 |   2 +-
> >>   hw/mips/mips_fulong2e.c                       |   2 +-
> >>   hw/mips/mips_jazz.c                           |   2 +-
> >>   hw/mips/mips_malta.c                          |   2 +-
> >>   hw/mips/mips_mipssim.c                        |   2 +-
> >>   hw/mips/mips_r4k.c                            |   2 +-
> >>   hw/mips/cputimer.c => target/mips/cp0_timer.c |   2 +-
> >>   target/mips/cpu.c                             |  57 +++-
> >>   target/mips/gdbstub.c                         |   1 +
> >>   target/mips/helper.c                          |  47 +++
> >>   target/mips/kvm.c                             |   1 +
> >>   target/mips/machine.c                         |   1 +
> >>   target/mips/msa_helper.c                      |   1 +
> >>   target/mips/op_helper.c                       |   1 +
> >>   target/mips/translate.c                       |  23 +-
> >>   target/mips/translate_init.c                  |  68 +----
> >>   hw/mips/Makefile.objs                         |   2 +-
> >>   target/mips/Makefile.objs                     |   2 +-
> >>   21 files changed, 549 insertions(+), 449 deletions(-)
> >>   create mode 100644 target/mips/internal.h
> >>   rename hw/mips/cputimer.c => target/mips/cp0_timer.c (99%)  
>