[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/10] Correct two minor QMP int
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/10] Correct two minor QMP interface design flaws |
Date: |
Thu, 17 Aug 2017 06:53:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
John Snow <address@hidden> writes:
[...]
> On 07/20/2017 03:53 AM, Markus Armbruster wrote:
>> blockdev-add and migrate-set-parameters overload empty strings to mean
>> something entirely different. See my memo "qapi: Stop abusing
>> "special" values for something entirely different" for details.
>>
>> Message-ID: <address@hidden>
>> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04526.html
>>
>> This series deprecates these usages of "" in favour of JSON null.
>> Because we're so close to the 2.10 freeze, the implementation is
>> intentionally stupid: rewrite null to "" at first opportunity. The
>> proper way to do it would be rewriting "" to null, but that requires
>> fixing up code to work with null. There are TODO comments for that.
>> I'm willing to take care of them in the next development cycle.
>>
>
> Did this get dropped in favor of a more comprehensive 2.11 fix?
This is the stupid solution for 2.10. TODO comments in PATCH 05+08-10
mark the spots that could use cleanup. I hope to get to them in 2.11.
[...]