Re: [Qemu-devel] [PATCH] PCI: PCIe access should always be little endian

[Marcel Apfelbaum]

On 15/08/2017 17:44, Matt Redfearn wrote:
> PCIe busses are always little endian, so set the endianness of the
> memory region to little endian rather than native such that operations
> work as expected on big endian targets.
>
> Signed-off-by: Matt Redfearn <address@hidden>


Hi Matt,
Thanks for the patch.

> ---
>
>   hw/pci/pcie_host.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie_host.c b/hw/pci/pcie_host.c
> index dcebf57ed45e..553db56778b6 100644
> --- a/hw/pci/pcie_host.c
> +++ b/hw/pci/pcie_host.c
> @@ -81,7 +81,7 @@ static uint64_t pcie_mmcfg_data_read(void *opaque,
>   static const MemoryRegionOps pcie_mmcfg_ops = {
>       .read = pcie_mmcfg_data_read,
>       .write = pcie_mmcfg_data_write,
> -    .endianness = DEVICE_NATIVE_ENDIAN,
> +    .endianness = DEVICE_LITTLE_ENDIAN,
>   };
>   
>   static void pcie_host_init(Object *obj)


Reviewed-by: Marcel Apfelbaum <address@hidden>

Thanks,
Marcel