Re: [Qemu-devel] [PATCH for-2.10 v2 2/2] simpletrace: fix flight recorder --no-header option

[Daniel P. Berrange]

On Tue, Aug 15, 2017 at 09:44:30AM +0100, Stefan Hajnoczi wrote:
> The simpletrace.py script can pretty-print flight recorder ring buffers.
> These are not full simpletrace binary trace files but just the end of a
> trace file.  There is no header and the event ID mapping information is
> often unavailable since the ring buffer may have filled up and discarded
> event ID mapping records.
> 
> The simpletrace.stp script that generates ring buffer traces uses the
> same trace-events-all input file as simpletrace.py.  Therefore both
> scripts have the same global ordering of trace events.  A dynamic event
> ID mapping isn't necessary: just use the trace-events-all file as the
> reference for how event IDs are numbered.
> 
> It is now possible to analyze simpletrace.stp ring buffers again using:
> 
>   $ ./simpletrace.py trace-events-all path/to/ring-buffer
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  scripts/simpletrace.py | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|