[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: Let "make check-help" work without ru
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: Let "make check-help" work without running ./configure |
Date: |
Tue, 15 Aug 2017 15:09:27 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Thu, 08/10 08:59, Philippe Mathieu-Daudé wrote:
> Hi Fam,
>
> thank for fixing this :)
>
> I think as a bugfix it should enter 2.10
> (maybe through Alex's Travis series, CC'ing him)
Since Alex hasn't replied, I'll send a pull request for -rc3.
>
> On 08/10/2017 05:50 AM, Fam Zheng wrote:
> > Currently if you do "make check-help" in a fresh checkout, only an error
> > is printed which is not nice:
> >
> > $ make check-help V=1
> > cc -nostdlib -o check-help.mo
> > cc: fatal error: no input files
> > compilation terminated.
> > rules.mak:115: recipe for target 'check-help.mo' failed
> > make: *** [check-help.mo] Error 1
> >
> > Move the config-host.mak condition into the body of
> > tests/Makefile.include and always include the rule for check-help.
> >
> > Reported-by: Philippe Mathieu-Daudé <address@hidden>
> > Signed-off-by: Fam Zheng <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
Fam