[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 03/19] migration: Add comments to channel fun
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v6 03/19] migration: Add comments to channel functions |
Date: |
Thu, 10 Aug 2017 15:57:59 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Aug 08, 2017 at 06:26:13PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration/channel.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/migration/channel.c b/migration/channel.c
> index edceebd..79b0f8b 100644
> --- a/migration/channel.c
> +++ b/migration/channel.c
> @@ -19,6 +19,14 @@
> #include "qapi/error.h"
> #include "io/channel-tls.h"
>
> +/**
> + * @migration_channel_process_incoming - Create new incoming migration
> channel
> + *
> + * Notice that TLS is special. For it we listen in a listener socket,
> + * and then create a new client socket from the TLS library.
> + *
> + * @ioc: Channel to wich we are connecting
> + */
s/wich/which/
> void migration_channel_process_incoming(QIOChannel *ioc)
> {
> MigrationState *s = migrate_get_current();
> @@ -41,6 +49,13 @@ void migration_channel_process_incoming(QIOChannel *ioc)
> }
>
>
> +/**
> + * @migration_channel_connect - Create new outgoing migration channel
> + *
> + * @s: Current migration state
> + * @ioc: Channel to wich we are connecting
s/wich/which/
> + * @hostname: Where we want to connect
> + */
> void migration_channel_connect(MigrationState *s,
> QIOChannel *ioc,
> const char *hostname)
> --
> 2.9.4
With those typos fixed, you can add
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v6 15/19] migration: Create thread infrastructure for multifd recv side, (continued)
- [Qemu-devel] [PATCH v6 15/19] migration: Create thread infrastructure for multifd recv side, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 17/19] migration: Rename initial_bytes, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 16/19] migration: Test new fd infrastructure, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 18/19] migration: Transfer pages over new channels, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 19/19] migration: Flush receive queue, Juan Quintela, 2017/08/08
- Re: [Qemu-devel] [PATCH v6 00/19] Multifd, no-reply, 2017/08/08
- [Qemu-devel] [PATCH v6 00/19] Multifd, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 01/19] migration: Create migration_ioc_process_incoming(), Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 03/19] migration: Add comments to channel functions, Juan Quintela, 2017/08/08
- Re: [Qemu-devel] [PATCH v6 03/19] migration: Add comments to channel functions,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v6 02/19] migration: Teach it about G_SOURCE_REMOVE, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 04/19] migration: Create migration_has_all_channels, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 05/19] qio: Create new qio_channel_{readv, writev}_all, Juan Quintela, 2017/08/08
- [Qemu-devel] [PATCH v6 06/19] migration: Add multifd capability, Juan Quintela, 2017/08/08