[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code |
Date: |
Wed, 9 Aug 2017 17:18:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/09/2017 04:54 PM, Paolo Bonzini wrote:
> This includes shell function, shell variables, command line options
> (randomize.awk does not exist) and conditions that can never be true
> (./qemu does not exist anymore).
Can we point to a commit id where we stopped making ./qemu? Is it still
worth supporting a local symlink?
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> tests/qemu-iotests/check | 36 +--------------------
> tests/qemu-iotests/common | 23 --------------
> tests/qemu-iotests/common.config | 26 ---------------
> tests/qemu-iotests/common.rc | 68
> ----------------------------------------
> 4 files changed, 1 insertion(+), 152 deletions(-)
>
> -#
> -# - These can be added to $HOST_CONFIG_DIR (witch default to ./config)
Good riddance to the wrong word ('which' was intended)
Other than possibly still wanting ./qemu convenience, this looks like a
reasonable cleanup.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/12] cleanup qemu-iotests, Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 02/12] qemu-iotests: get rid of AWK_PROG, Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 03/12] qemu-iotests: move "check" code out of common.rc, Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code, Paolo Bonzini, 2017/08/09
- Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code,
Eric Blake <=
- [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc, Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 06/12] qemu-iotests: do not do useless search for QEMU_*_PROG, Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 05/12] qemu-iotests: do not include common.rc in "check", Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 08/12] qemu-iotests: fix uninitialized variable, Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config, Paolo Bonzini, 2017/08/09
- [Qemu-devel] [PATCH 09/12] qemu-iotests: do not search for binaries in the current directory, Paolo Bonzini, 2017/08/09