Re: [Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features

[Cornelia Huck]

On Wed, 9 Aug 2017 15:25:36 +0200
David Hildenbrand <address@hidden> wrote:

> > A comment which subfunction this is might be helpful.  
> 
> Indeed.
> 
> /* query subfunction */

Looks good!

> 
> >   
> >> +        for (i = 0; i < 16; i++) {
> >> +            param_addr = wrap_address(env, env->regs[1] + i);  
> > 
> > This does not compile for me (after massaging the Makefile above), as
> > wrap_address does not seem to be exported... can you do a respin,
> > please?
> >   
> 
> Contained in patch nr4 in this series. But I'm planning to do a respin
> (most likely introducing internal.h).

Ah yes, that issue had dropped out of my cache :)

I'll just wait for a respin of your pending patches, then.