[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] block-backend: shift in-flight counter to B
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS |
Date: |
Tue, 8 Aug 2017 14:48:14 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/08/2017 02:34 PM, Paolo Bonzini wrote:
>
>
> ----- Original Message -----
>> From: "John Snow" <address@hidden>
>> To: address@hidden
>> Cc: address@hidden, address@hidden, address@hidden, address@hidden,
>> address@hidden,
>> address@hidden, "John Snow" <address@hidden>
>> Sent: Tuesday, August 8, 2017 7:57:10 PM
>> Subject: [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS
>>
>> From: Kevin Wolf <address@hidden>
>>
>> This allows us to detect errors in cache flushing (ENOMEDIUM)
>> without choking on a null dereference because we assume that
>> blk_bs(bb) is always defined.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> Signed-off-by: John Snow <address@hidden>
>
> This is not enough, as discussed in the thread.
>
> Paolo
>
Sure, I amended Kevin's later fix and rolled it into one patch and split
the tests out. The cover letter states that this is busted, but I wanted
it on the list instead of buried in a now-unrelated thread.
So now it's here as a patch, can we keep discussion here instead of on
the other thread?
--John
- [Qemu-devel] [PATCH 0/4] IDE: Do not flush empty drives, John Snow, 2017/08/08
- [Qemu-devel] [PATCH 1/4] IDE: Do not flush empty CDROM drives, John Snow, 2017/08/08
- [Qemu-devel] [PATCH 2/4] IDE: test flush on empty CDROM, John Snow, 2017/08/08
- [Qemu-devel] [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS, John Snow, 2017/08/08
- [Qemu-devel] [PATCH 4/4] block-backend: test flush op on empty backend, John Snow, 2017/08/08
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] IDE: Do not flush empty drives, Stefan Hajnoczi, 2017/08/09