[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 14/17] migration: Delay the start of receptio
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v5 14/17] migration: Delay the start of reception on main channel |
Date: |
Tue, 08 Aug 2017 13:29:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> When we start multifd, we will want to delay the main channel until
>> the others are created.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> migration/migration.c | 23 ++++++++++++++---------
>> 1 file changed, 14 insertions(+), 9 deletions(-)
>>
>> diff --git a/migration/migration.c b/migration/migration.c
>> index d9d5415..e122684 100644
>> --- a/migration/migration.c
>> +++ b/migration/migration.c
>> @@ -358,14 +358,11 @@ static void process_incoming_migration_co(void *opaque)
>>
>> static void migration_incoming_setup(QEMUFile *f)
>> {
>> - MigrationIncomingState *mis = migration_incoming_get_current();
>> -
>> if (multifd_load_setup() != 0) {
>> /* We haven't been able to create multifd threads
>> nothing better to do */
>> exit(EXIT_FAILURE);
>> }
>> - mis->from_src_file = f;
>> qemu_file_set_blocking(f, false);
>> }
>>
>> @@ -384,18 +381,26 @@ void migration_fd_process_incoming(QEMUFile *f)
>> gboolean migration_ioc_process_incoming(QIOChannel *ioc)
>> {
>> MigrationIncomingState *mis = migration_incoming_get_current();
>> + gboolean result = FALSE;
>
> I wonder if we need some state somewhere so that we can see that the
> incoming migration is partially connected - since the main incoming
> coroutine hasn't started yet, we've not got much of mis setup.
For other reasons this code has changed, and now this variable don't
exist.
Later, Juan.
- Re: [Qemu-devel] [PATCH v5 14/17] migration: Delay the start of reception on main channel,
Juan Quintela <=