[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: skip implicit nodes in snapshots, bl
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: skip implicit nodes in snapshots, blockjobs |
Date: |
Wed, 2 Aug 2017 10:52:26 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Aug 01, 2017 at 04:49:06PM +0300, Manos Pitsidianakis wrote:
> diff --git a/block.c b/block.c
> index 886a457ab0..9ebdba28b0 100644
> --- a/block.c
> +++ b/block.c
> @@ -4947,3 +4947,20 @@ bool bdrv_can_store_new_dirty_bitmap(BlockDriverState
> *bs, const char *name,
>
> return drv->bdrv_can_store_new_dirty_bitmap(bs, name, granularity, errp);
> }
> +
> +/* Get first non-implicit node down a bs chain. */
> +BlockDriverState *bdrv_get_first_non_implicit(BlockDriverState *bs)
Linguistically non-implicit == explicit and that would be simpler.
Alternatives to implicit/explicit are:
transient/permanent
internal/external
self-created/user-created
worker/user
Let's agree on one and use it consistently. I like the worker nodes vs
user nodes because it reflects their function.
implicit/explicit is fine by me too. I just think non-implicit is
clunky.
signature.asc
Description: PGP signature