[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/9] checkpatch: check trace-events code style
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 7/9] checkpatch: check trace-events code style |
Date: |
Tue, 1 Aug 2017 14:16:16 +0100 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
According to CODING_STYLE, check that in trace-events:
1. hex numbers are prefixed with '0x'
2. '#' flag of printf is not used
3. The exclusion from 1. are period-separated groups of numbers
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
scripts/checkpatch.pl | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4e91122813..fa478074b8 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1337,6 +1337,25 @@ sub process {
$rpt_cleaners = 1;
}
+# checks for trace-events files
+ if ($realfile =~ /trace-events$/ && $line =~ /^\+/) {
+ if ($rawline =~ /%[-+ 0]*#/) {
+ ERROR("Don't use '#' flag of printf format
('%#') in " .
+ "trace-events, use '0x' prefix instead\n"
. $herecurr);
+ } else {
+ my $hex =
+ qr/%[-+
*.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;
+
+ # don't consider groups splitted by [.:/ ],
like 2A.20:12ab
+ my $tmpline = $rawline =~ s/($hex[.:\/
])+$hex//gr;
+
+ if ($tmpline =~ /(?<!0x)$hex/) {
+ ERROR("Hex numbers must be prefixed
with '0x'\n" .
+ $herecurr);
+ }
+ }
+ }
+
# check we are in a valid source file if not then ignore this hunk
next if ($realfile !~ /\.(h|c|cpp|s|S|pl|py|sh)$/);
--
2.13.3
- [Qemu-devel] [PULL 0/9] Tracing patches, Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 2/9] trace: ensure unique function / variable names per .stp file, Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 1/9] trace: ensure .stp files are rebuilt if trace tool source changes, Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 3/9] trace: add TRACE_<event>_BACKEND_DSTATE(), Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 4/9] trace: add trace_event_get_state_backends(), Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 5/9] coding_style: add point about 0x in trace-events, Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 6/9] trace-events: fix code style: %# -> 0x%, Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 7/9] checkpatch: check trace-events code style,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 9/9] monitor: Reduce handle_qmp_command() tracing overhead, Stefan Hajnoczi, 2017/08/01
- [Qemu-devel] [PULL 8/9] trace-events: fix code style: print 0x before hex numbers, Stefan Hajnoczi, 2017/08/01
- Re: [Qemu-devel] [PULL 0/9] Tracing patches, no-reply, 2017/08/01
- Re: [Qemu-devel] [PULL 0/9] Tracing patches, Peter Maydell, 2017/08/01