[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert()
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert() |
Date: |
Tue, 1 Aug 2017 09:40:09 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
* Peter Xu (address@hidden) wrote:
> On Mon, Jul 31, 2017 at 06:11:56PM +0100, Dr. David Alan Gilbert wrote:
> > * Peter Xu (address@hidden) wrote:
> > > It is used to invert the whole bitmap.
> >
> > Would it be easier to change bitmap_complement to use ^
> > in it's macro and slow_bitmap_complement, and then you could call it
> > with src==dst to do the same thing with just that small change?
>
> Or, I can directly use that and drop this patch. :-)
Yes, that's fine - note the only difference I see is what happens to the
bits in the last word after the end of the count; your code leaves them
as is, the complement code will zero them on the destination I think.
Dave
> (I didn't really notice that one before)
>
> Thanks,
>
> --
> Peter Xu
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert(),
Dr. David Alan Gilbert <=