Re: [Qemu-devel] [PATCH v3 2/4] trace-events: fix code style: %# -> 0x%

[Eric Blake]

On 07/31/2017 11:01 AM, Vladimir Sementsov-Ogievskiy wrote:
> In trace format '#' flag of printf is forbidden. Fix it to '0x%'.
> 
> This patch is created by the following:
> 
> check that we have a problem
>> find . -name trace-events | xargs grep '%#' | wc -l
> 56
> 
> check that there are no cases with additional printf flags before '#'
>> find . -name trace-events | xargs grep '%[-+ 0'I]+#' | wc -l

That's not the actual command you used; maintainer can fix the typo by
using "%[-+ 0'I]+#" instead.

> 0
> 
> check that there are no wrong usage of '#' and '0x' together
>> find . -name trace-events | xargs grep '0x%#' | wc -l
> 0
> 
> fix the problem
>> find . -name trace-events | xargs sed -i 's/%#/0x%/g'
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature