[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 06/29] migration: dump str in migrate_set_state trace
From: |
Peter Xu |
Subject: |
[Qemu-devel] [RFC 06/29] migration: dump str in migrate_set_state trace |
Date: |
Fri, 28 Jul 2017 16:06:15 +0800 |
Strings are more readable for debugging.
Signed-off-by: Peter Xu <address@hidden>
---
migration/migration.c | 3 ++-
migration/trace-events | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 6803187..bdc4445 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -914,8 +914,9 @@ void qmp_migrate_start_postcopy(Error **errp)
void migrate_set_state(int *state, int old_state, int new_state)
{
+ assert(new_state < MIGRATION_STATUS__MAX);
if (atomic_cmpxchg(state, old_state, new_state) == old_state) {
- trace_migrate_set_state(new_state);
+ trace_migrate_set_state(MigrationStatus_lookup[new_state]);
migrate_generate_event(new_state);
}
}
diff --git a/migration/trace-events b/migration/trace-events
index cb2c4b5..08d00fa 100644
--- a/migration/trace-events
+++ b/migration/trace-events
@@ -80,7 +80,7 @@ ram_save_queue_pages(const char *rbname, size_t start, size_t
len) "%s: start: %
# migration/migration.c
await_return_path_close_on_source_close(void) ""
await_return_path_close_on_source_joining(void) ""
-migrate_set_state(int new_state) "new state %d"
+migrate_set_state(const char *new_state) "new state %s"
migrate_fd_cleanup(void) ""
migrate_fd_error(const char *error_desc) "error=%s"
migrate_fd_cancel(void) ""
--
2.7.4
- [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState, (continued)
- [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState, Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling, Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert(), Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 05/29] bitmap: introduce bitmap_count_one(), Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 06/29] migration: dump str in migrate_set_state trace,
Peter Xu <=
- [Qemu-devel] [RFC 08/29] migration: reuse mis->userfault_quit_fd, Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 07/29] migration: better error handling with QEMUFile, Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 09/29] migration: provide postcopy_fault_thread_notify(), Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 10/29] migration: new property "x-postcopy-fast", Peter Xu, 2017/07/28