[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code |
Date: |
Fri, 28 Jul 2017 09:26:20 +0200 |
On Fri, 28 Jul 2017 15:12:25 +0800
Dong Jia Shi <address@hidden> wrote:
> * Cornelia Huck <address@hidden> [2017-07-27 12:10:17 +0200]:
> > Do we want to add all ERCs while we're at it?
> >
> > > +#define CRW_ERC_INIT 0x02
> > > +#define CRW_ERC_IPI 0x04
> No problem for me. I can do that by stealing again:
>
> #define CRW_ERC_EVENT 0x00 /* event information pending */
> #define CRW_ERC_AVAIL 0x01 /* available */
> #define CRW_ERC_INIT 0x02 /* initialized */
> #define CRW_ERC_TERROR 0x03 /* temporary error */
> #define CRW_ERC_IPI 0x04 /* installed parm initialized */
> #define CRW_ERC_TERM 0x05 /* terminal */
> #define CRW_ERC_PERRN 0x06 /* perm. error, facility not init */
> #define CRW_ERC_PERRI 0x07 /* perm. error, facility init */
> #define CRW_ERC_PMOD 0x08 /* installed parameters modified */
>
> Want the comment or not? I like them.
Yes, just do it.
>
> > >
> > > #define CRW_RSC_SUBCH 0x3
> > > #define CRW_RSC_CHP 0x4
> >
>
[Qemu-devel] [PATCH 3/3] s390x/css: generate channel path initialized CRW for channel path hotplug, Dong Jia Shi, 2017/07/26