qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public


From: Amador Pahim
Subject: Re: [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public
Date: Thu, 27 Jul 2017 16:59:51 +0200

On Thu, Jul 27, 2017 at 4:18 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Tue, Jul 25, 2017 at 07:10:09PM +0200, Amador Pahim wrote:
>> Let's make args public so users can extend it in instances
>> without feeling like abusing the internal API.
>>
>> Signed-off-by: Amador Pahim <address@hidden>
>> ---
>>  scripts/qemu.py               | 14 +++++++-------
>>  tests/qemu-iotests/iotests.py | 18 +++++++++---------
>>  2 files changed, 16 insertions(+), 16 deletions(-)
>
> As discussed in the previous revision, I don't think this patch is
> justified because all current users just need a protected field.  There
> are no users who need the field to be public so this change is
> premature.

Indeed. It will be removed from the next version.

>
> Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]