Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

[Daniel P. Berrange]

On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote:
> On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> > Add multimedia keys to QKeyCodes and to the keymaps.
> > 
> > Signed-off-by: Gerd Hoffmann <address@hidden>
> > ---
> >  ui/input-keymap.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >  qapi-schema.json  | 17 ++++++++++++++++-
> >  2 files changed, 60 insertions(+), 1 deletion(-)
> 
> > +++ b/qapi-schema.json
> > @@ -4843,6 +4843,16 @@
> >  # @henkan: since 2.9
> >  # @yen: since 2.9
> >  #
> > +# @sleep: since 2.10
> > +# @wake: since 2.10
> > +# @audio*: since 2.10
> > +# @volume*: since 2.10
> > +# @mediaselect: since 2.10
> > +# @mail: since 2.10
> > +# @calculator: since 2.10
> > +# @computer: since 2.10
> > +# @ac_*: since 2.10
> 
> Borderline between bug-fix and new feature (arguing that the bug is that
> we don't represent all keys).  Does this need to be 2.11 instead?

It is really fixing a bug introduced in the PS2 driver in 2.8.0.  It
roundtrips via QKeyCode now, so any key where there is an AT Set 1
scancode defined, but for which we lack a QKeyCode can't be sent to
guests since QEMU 2.8.0 onwards.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|