Re: [Qemu-devel] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source

[David Gibson]

On Tue, Jul 25, 2017 at 03:47:37PM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2017-07-25 at 14:18 +1000, David Gibson wrote:
> > > Well, at this point I think nothing will set that flag.... It's there
> > > for workaround around HW bugs on some chips. At least in full emu it
> > > shouldn't happen unless we try to emulate those bugs. Hopefully direct
> > > MMIO will just work.
> > 
> > Hm.  That doesn't seem like a good match for a per-irq state
> > structure.
> 
> The flag is returned to the guest on a per-IRQ basis, so are the LSI
> etc... flags, but at the HW level, indeed, they correspond to
> attributes of blocks of interrupts.
> 
> It might be easier in qemu to keep that in the per-source flags
> though.

Yeah, I think so.

> Especially when we start having actual HW interrupts under the
> hood with KVM. it's easier to keep the state self contained
> for each of them.
> 
> Ben.
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature