[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 04/10] tests/test-qobject-input-visitor: Drop redu
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v2 04/10] tests/test-qobject-input-visitor: Drop redundant test |
Date: |
Mon, 24 Jul 2017 13:56:53 +0200 |
test_visitor_in_alternate() tests UserDefAlternate with inadmissible
input. test_visitor_in_fail_alternate() does basically the same.
Drop the former, keep the latter.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
---
tests/test-qobject-input-visitor.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tests/test-qobject-input-visitor.c
b/tests/test-qobject-input-visitor.c
index f451844..bcf0261 100644
--- a/tests/test-qobject-input-visitor.c
+++ b/tests/test-qobject-input-visitor.c
@@ -567,7 +567,6 @@ static void test_visitor_in_alternate(TestInputVisitorData
*data,
const void *unused)
{
Visitor *v;
- Error *err = NULL;
UserDefAlternate *tmp;
WrapAlternate *wrap;
@@ -599,11 +598,6 @@ static void test_visitor_in_alternate(TestInputVisitorData
*data,
g_assert_cmpint(tmp->u.udfu.u.value1.has_a_b, ==, false);
qapi_free_UserDefAlternate(tmp);
- v = visitor_input_test_init(data, "false");
- visit_type_UserDefAlternate(v, NULL, &tmp, &err);
- error_free_or_abort(&err);
- qapi_free_UserDefAlternate(tmp);
-
v = visitor_input_test_init(data, "{ 'alt': 42 }");
visit_type_WrapAlternate(v, NULL, &wrap, &error_abort);
g_assert_cmpint(wrap->alt->type, ==, QTYPE_QNUM);
--
2.7.5
- [Qemu-devel] [PULL v2 00/10] QAPI patches for 2017-07-18, Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 04/10] tests/test-qobject-input-visitor: Drop redundant test,
Markus Armbruster <=
- [Qemu-devel] [PULL v2 08/10] migration: Add TODO comments on duplication of QAPI_CLONE(), Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 03/10] qapi: Introduce a first class 'null' type, Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 01/10] qapi: Separate type QNull from QObject, Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 07/10] migration: Clean up around tls_creds, tls_hostname, Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 09/10] migration: Unshare MigrationParameters struct for now, Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 10/10] migration: Use JSON null instead of "" to reset parameter to default, Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 02/10] qapi: Use QNull for a more regular visit_type_null(), Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 05/10] block: Use JSON null instead of "" to disable backing file, Markus Armbruster, 2017/07/24
- [Qemu-devel] [PULL v2 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter(), Markus Armbruster, 2017/07/24
- Re: [Qemu-devel] [PULL v2 00/10] QAPI patches for 2017-07-18, Peter Maydell, 2017/07/24