Re: [Qemu-devel] [PATCH v3 0/5] target/s390x: Fix broken build with --disable-tcg

[Cornelia Huck]

On Mon, 24 Jul 2017 10:52:45 +0200
Thomas Huth <address@hidden> wrote:

> Our configure script was recently equipped with a new --disable-tcg
> parameter, but this does unfortunately not work on s390x hosts yet. Fix
> the build by moving some code around and by adding some few #ifdefs
> in the right places.
> 
> v3:
> - Fixed the problem when building the s390x-linux-user target
> - Added a g_assert_not_reached() to tcg_s390_program_interrupt()
>   according to Richard's suggestion

If I get one more R-b by Richard for patch 3 before tomorrow, I'll
merge that in.

> 
> v2:
> - Reworked the changes to program_interrupt() according to the
>   suggestions by Richard
> 
> Thomas Huth (5):
>   target/s390x: Move s390_cpu_dump_state() to helper.c
>   target/s390x: Move diag helpers to a separate file
>   target/s390x: Rework program_interrupt() and related functions
>   target/s390x: Move exception-related functions to a new excp_helper.c
>     file
>   target/s390x: Add remaining switches to compile with --disable-tcg
> 
>  target/s390x/Makefile.objs |   8 +-
>  target/s390x/cpu.c         |   4 +
>  target/s390x/cpu.h         |  17 +-
>  target/s390x/diag.c        | 179 +++++++++++++++
>  target/s390x/excp_helper.c | 515 +++++++++++++++++++++++++++++++++++++++++++
>  target/s390x/helper.c      | 528 
> +++++----------------------------------------
>  target/s390x/interrupt.c   |  39 ++++
>  target/s390x/kvm.c         |  16 +-
>  target/s390x/misc_helper.c | 193 -----------------
>  target/s390x/translate.c   |  60 ------
>  10 files changed, 819 insertions(+), 740 deletions(-)
>  create mode 100644 target/s390x/diag.c
>  create mode 100644 target/s390x/excp_helper.c
> 

Thanks, queued to s390-next.