qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] 答复: Re: 答复: Re: [PATCH] vhost: fix a migration failed


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] 答复: Re: 答复: Re: [PATCH] vhost: fix a migration failedbecause ofvhost region merge
Date: Sun, 23 Jul 2017 04:52:22 +0300

On Sat, Jul 22, 2017 at 01:49:20PM +0800, address@hidden wrote:
> some regions can not merge when just part of devices have realized.
> 
> when all devices are realized on destination, these regions  can be merged
>  again 
> 
>  and the used slots can satisfy the vhost slot limit as on source.
> 
> in the restore stage the vm is not in running state, so don't compute if more
> than 
> 
> vhost slot limit when vm is not running. when a last device is realized,
> 
> all regions are merged to the slot number as on source. then the state of vm 
> 
> changes to running.
> 
>  it satisfies the vhost slot limit on source, so it should satify on
> destination.

OK but the VM not running check is too hacky. E.g. it won't
trigger with memory hotplug if someone stops VM before
doing hotplug.

Looks like you want to check machine_init_done or something
like this.

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]