Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Hi
>
> On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster <address@hidden> wrote:
>> QMP command
>>
>>     { "execute": "change",
>>       "arguments": { "device": "vnc", "target": "password", "arg": PWD } }
>>
>> behaves just like
>>
>>     { "execute": "change-vnc-password",
>>       "arguments": { "password", "arg": PWD } }
>>
>> Their documentation differs, however.  According to
>> change-vnc-password's documentation, "an empty password [...] will set
>> the password to the empty string", while change's documentation claims
>> "no future logins will be allowed".  The former is actually correct.
>> Replace the incorrect claim by a reference to change-vnc-password.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Reviewed-by: Marc-André Lureau <address@hidden>
>
>
> The password would have to be NULL to disallow further login, is that
> what your other series will allow to do?

I guess it could be applied to change-vnc-password that way.