[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/14] tcg/tci: enable bswap16_i64
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 13/14] tcg/tci: enable bswap16_i64 |
Date: |
Tue, 18 Jul 2017 18:57:21 -1000 |
From: Philippe Mathieu-Daudé <address@hidden>
Altough correctly implemented, bswap16_i64() never got tested/executed so the
safety TODO() statement was never removed.
Since it got now tested the TODO() can be removed.
while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img:
Trace 0x7fa1904b0890 [0: ffffffc00036cd04]
----------------
IN:
0xffffffc00036cd24: 5ac00694 rev16 w20, w20
OP:
---- ffffffc00036cd24 0000000000000000 0000000000000000
ext32u_i64 tmp3,x20
ext16u_i64 tmp2,tmp3
bswap16_i64 x20,tmp2
movi_i64 tmp4,$0x10
shr_i64 tmp2,tmp3,tmp4
ext16u_i64 tmp2,tmp2
bswap16_i64 tmp2,tmp2
deposit_i64 x20,x20,tmp2,$0x10,$0x10
Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0
[ffffffc00036cd24]
Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24]
TODO qemu/tci.c:1049: tcg_qemu_tb_exec()
qemu/tci.c:1049: tcg fatal error
Aborted
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Jaroslaw Pelczar <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/tci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 4bdc645..f39bfb9 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t
*tb_ptr)
break;
#if TCG_TARGET_HAS_bswap16_i64
case INDEX_op_bswap16_i64:
- TODO();
t0 = *tb_ptr++;
t1 = tci_read_r16(&tb_ptr);
tci_write_reg64(t0, bswap16(t1));
--
2.9.4
- [Qemu-devel] [PULL 03/14] tcg: Expand glue macros before stringifying helper names, (continued)
- [Qemu-devel] [PULL 03/14] tcg: Expand glue macros before stringifying helper names, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 04/14] coccinelle: ignore ASTs pre-parsed cached C files, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 05/14] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 06/14] target/arm: Optimize aarch64 rev16, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 07/14] target/arm: optimize aarch32 rev16, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 08/14] target/m68k: optimize bcd_flags() using extract op, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 09/14] target/ppc: optimize various functions using extract op, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 10/14] target/sparc: optimize various functions using extract op, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 11/14] target/sparc: optimize gen_op_mulscc() using deposit op, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 12/14] target/alpha: optimize gen_cvtlq() using deposit op, Richard Henderson, 2017/07/19
- [Qemu-devel] [PULL 13/14] tcg/tci: enable bswap16_i64,
Richard Henderson <=
- [Qemu-devel] [PULL 14/14] tcg: Pass generic CPUState to gen_intermediate_code(), Richard Henderson, 2017/07/19
- Re: [Qemu-devel] [PULL 00/14] tcg-next patch queue, no-reply, 2017/07/19
- Re: [Qemu-devel] [PULL 00/14] tcg-next patch queue, Peter Maydell, 2017/07/19