[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 0/4] bsd-user: silence warnings on Open
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 0/4] bsd-user: silence warnings on OpenBSD |
Date: |
Tue, 18 Jul 2017 14:29:03 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH for-2.10 0/4] bsd-user: silence warnings on OpenBSD
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
2205391 bsd-user/main.c: Fix unused variable warning
72ca90a bsd-user/bsdload.c: Remove write-only id_change variable
8d5f872 bsd-user/elfload.c: Fix set-but-not-used warnings
684257a bsd-user/mmap.c: Move __thread attribute to right place
=== OUTPUT BEGIN ===
Checking PATCH 1/4: bsd-user/mmap.c: Move __thread attribute to right place...
Checking PATCH 2/4: bsd-user/elfload.c: Fix set-but-not-used warnings...
Checking PATCH 3/4: bsd-user/bsdload.c: Remove write-only id_change variable...
Checking PATCH 4/4: bsd-user/main.c: Fix unused variable warning...
ERROR: if this code is redundant consider removing it
#26: FILE: bsd-user/main.c:622:
+#if 0
total: 1 errors, 0 warnings, 13 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH for-2.10 0/4] bsd-user: silence warnings on OpenBSD, Peter Maydell, 2017/07/18
- [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning, Peter Maydell, 2017/07/18
- [Qemu-devel] [PATCH for-2.10 3/4] bsd-user/bsdload.c: Remove write-only id_change variable, Peter Maydell, 2017/07/18
- [Qemu-devel] [PATCH for-2.10 2/4] bsd-user/elfload.c: Fix set-but-not-used warnings, Peter Maydell, 2017/07/18
- [Qemu-devel] [PATCH for-2.10 1/4] bsd-user/mmap.c: Move __thread attribute to right place, Peter Maydell, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 0/4] bsd-user: silence warnings on OpenBSD,
no-reply <=
- Re: [Qemu-devel] [PATCH for-2.10 0/4] bsd-user: silence warnings on OpenBSD, Peter Maydell, 2017/07/21