[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'n
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type |
Date: |
Tue, 18 Jul 2017 22:27:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 07/18/2017 02:43 PM, Markus Armbruster wrote:
>> @@ -536,10 +537,11 @@ can only express a choice between types represented
>> differently in
>> JSON. If a branch is typed as the 'bool' built-in, the alternate
>> accepts true and false; if it is typed as any of the various numeric
>> built-ins, it accepts a JSON number; if it is typed as a 'str'
>> -built-in or named enum type, it accepts a JSON string; and if it is
>> -typed as a complex type (struct or union), it accepts a JSON object.
>> -Two different complex types, for instance, aren't permitted, because
>> -both are represented as a JSON object.
>> +built-in or named enum type, it accepts a JSON string; if it is typed
>> +as the 'null' built-in, it accepts JSON null, and if it is typed as a
>> +complex type (struct or union), it accepts a JSON object. Two
>
> Grammar tweak: s/null,/null;/
>
> In a list of phrases that all have commas, it's typical to graduate the
> list separator to semicolon, so that it becomes easier to see the flow
> of 'a,b; a,b; and a,b'
Fixed, thanks!
- Re: [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file, (continued)
- [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Markus Armbruster, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Eric Blake, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Eric Blake, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Markus Armbruster, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Markus Armbruster, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Eric Blake, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Markus Armbruster, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Eric Blake, 2017/07/18
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Markus Armbruster, 2017/07/18
Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Daniel P. Berrange, 2017/07/18
[Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter(), Markus Armbruster, 2017/07/18
[Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject, Markus Armbruster, 2017/07/18