[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Unified Socket Transport
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH] Unified Socket Transport |
|
Date: |
Tue, 18 Jul 2017 08:27:13 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Jul 18, 2017 at 07:06:27AM +0100, address@hidden wrote:
> From: Anton Ivanov <address@hidden>
>
> 1. Creates a common recvmmsg backend for socket transports
> 2. Migrates L2TPv3 to the new backend
> 3. Adds gre socket transport - a vm can attach directly to GRE
> 4. Adds raw socket transport - a vm can attach directly to an
> Ethernet interface
> 5. Adds simplistic static VXLAN tunnel transport (no
> control plane).
> 6. Sets up some of the infrastructure for future addition of
> sendmmsg
This list of features is a really strong sign that you should split
this patch up into a patch series with multiple commits, each commit
adding / changing a single feature. Especially keep refactoring of
existing code completely separate from adding of new features.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|