[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] add scripts/indent.sh
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH] add scripts/indent.sh |
Date: |
Mon, 17 Jul 2017 11:11:21 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] add scripts/indent.sh
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8352810 add scripts/indent.sh
=== OUTPUT BEGIN ===
Checking PATCH 1/1: add scripts/indent.sh...
ERROR: code indent should never use tabs
#22: FILE: scripts/indent.sh:6:
+indent^I--ignore-profile^I\$
ERROR: code indent should never use tabs
#23: FILE: scripts/indent.sh:7:
+^I--k-and-r-style^I^I\$
ERROR: code indent should never use tabs
#24: FILE: scripts/indent.sh:8:
+^I--line-length 80^I\$
ERROR: code indent should never use tabs
#25: FILE: scripts/indent.sh:9:
+^I--indent-level 4^I\$
ERROR: code indent should never use tabs
#26: FILE: scripts/indent.sh:10:
+^I--no-tabs^I^I\$
ERROR: code indent should never use tabs
#27: FILE: scripts/indent.sh:11:
+^I"$@"$
total: 6 errors, 0 warnings, 11 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden