Re: [Qemu-devel] [PULL v2 7/8] qga: Add 'guest-get-users' command

[Tomáš Golembiovský]

On Thu, 13 Jul 2017 15:56:25 +0100
Peter Maydell <address@hidden> wrote:

> On 27 April 2017 at 06:46, Michael Roth <address@hidden> wrote:
> > From: Vinzenz Feenstra <address@hidden>
> >
> > A command that will list all currently logged in users, and the time
> > since when they are logged in.
> >
> > Examples:
> >
> > virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }'
> > {"return":[{"login-time":1490622289.903835,"user":"root"}]}
> >
> > virsh # qemu-agent-command Win2k12r2 '{ "execute": "guest-get-users" }'
> > {"return":[{"login-time":1490351044.670552,"domain":"LADIDA",
> > "user":"Administrator"}]}
> >
> > Signed-off-by: Vinzenz Feenstra <address@hidden>
> > * make g_hash_table_contains compat func inline to avoid
> >   unused warnings
> > Signed-off-by: Michael Roth <address@hidden>
> 
> > diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> > index 915df9e..ba06be4 100644
> > --- a/qga/commands-posix.c
> > +++ b/qga/commands-posix.c
> > @@ -15,6 +15,7 @@
> >  #include <sys/ioctl.h>
> >  #include <sys/wait.h>
> >  #include <dirent.h>
> > +#include <utmpx.h>
> 
> Hi. I've just noticed that this breaks the build on OpenBSD,
> which doesn't have utmpx.h or the functions it provides.
> OpenBSD is currently close to falling off our list of
> hosts we care about, but still it would be nice if we
> could do a configure check for utmpx.h and have a fallback
> 'unsupported' code path for hosts where it doesn't exist.

Hi,

I have just sent a patch that should fix this.

https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg05086.html

Could you please test if it solves the issue properly?

Thanks,

    Tomas Golembiovsky

> 
> thanks
> -- PMM
> 


-- 
Tomáš Golembiovský <address@hidden>