Re: [Qemu-devel] [PATCH v3 1/9] virtio: enhance virtio_error messages

[Cornelia Huck]

On Mon, 17 Jul 2017 10:11:44 +0200
Ladi Prosek <address@hidden> wrote:

> Output like "Virtqueue size exceeded" is not much useful in identifying the

s/much/very/

> culprit. This commit adds virtio device name (e.g. "virtio-input") and id
> if set (e.g. "mouse0") to all virtio error messages to improve debuggability.
> 
> Some virtio devices (virtio-scsi, virtio-serial) insert a bus between the
> proxy object and the virtio backends, so a helper function is added to walk
> the object hierarchy and find the right proxy object to extract the id from.
> 
> Suggested-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Ladi Prosek <address@hidden>
> ---
>  hw/virtio/virtio.c | 30 ++++++++++++++++++++++++++++--
>  1 file changed, 28 insertions(+), 2 deletions(-)

Reviewed-by: Cornelia Huck <address@hidden>