qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 2/4] slirp: fork_exec(): Don't close() a negative num


From: Samuel Thibault
Subject: [Qemu-devel] [PULL 2/4] slirp: fork_exec(): Don't close() a negative number in fork_exec()
Date: Sat, 15 Jul 2017 14:30:55 +0200

From: Peter Maydell <address@hidden>

In a fork_exec() error path we try to closesocket(s) when s might
be a negative number because the thing that failed was the
qemu_socket() call. Add a guard so we don't do this.

(Spotted by Coverity: CID 1005727 issue 1 of 2.)

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Samuel Thibault <address@hidden>
---
 slirp/misc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/slirp/misc.c b/slirp/misc.c
index 88e9d94197..260187b6b6 100644
--- a/slirp/misc.c
+++ b/slirp/misc.c
@@ -112,7 +112,9 @@ fork_exec(struct socket *so, const char *ex, int do_pty)
                    bind(s, (struct sockaddr *)&addr, addrlen) < 0 ||
                    listen(s, 1) < 0) {
                        error_report("Error: inet socket: %s", strerror(errno));
-                       closesocket(s);
+                       if (s >= 0) {
+                           closesocket(s);
+                       }
 
                        return 0;
                }
-- 
2.13.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]