[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support |
Date: |
Sat, 15 Jul 2017 03:50:39 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d5870df cryptodev-vhost-user: add crypto session handler
67fb226 cryptodev: add vhost support
63cfcba cryptodev: add vhost-user as a new cryptodev backend
=== OUTPUT BEGIN ===
Checking PATCH 1/3: cryptodev: add vhost-user as a new cryptodev backend...
Checking PATCH 2/3: cryptodev: add vhost support...
Checking PATCH 3/3: cryptodev-vhost-user: add crypto session handler...
ERROR: suspect code indent for conditional statements (5, 9)
#32: FILE: backends/cryptodev-vhost-user.c:244:
+ if (vhost_crypto) {
+ struct vhost_dev *dev = &(vhost_crypto->dev);
ERROR: suspect code indent for conditional statements (9, 13)
#37: FILE: backends/cryptodev-vhost-user.c:249:
+ if (ret < 0) {
+ return -1;
total: 2 errors, 0 warnings, 236 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [RFC 0/3] cryptodev: add vhost support, Gonglei, 2017/07/15
- [Qemu-devel] [RFC 2/3] cryptodev: add vhost support, Gonglei, 2017/07/15
- [Qemu-devel] [RFC 1/3] cryptodev: add vhost-user as a new cryptodev backend, Gonglei, 2017/07/15
- [Qemu-devel] [RFC 3/3] cryptodev-vhost-user: add crypto session handler, Gonglei, 2017/07/15
- Re: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support, no-reply, 2017/07/15
- Re: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support,
no-reply <=
- Re: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support, no-reply, 2017/07/15
- Re: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support, Stefan Hajnoczi, 2017/07/17