Re: [Qemu-devel] [PATCH] vmgenid-test: use boot-sector infrastructure

[Peter Maydell]

On 14 July 2017 at 16:13, Michael S. Tsirkin <address@hidden> wrote:
> There's no requirement for RSDP to be installed last
> by the firmware, so in rare cases vmgen id test hits
> a race: RSDP is there but VM GEN ID isn't.
>
> To fix, switch to common boot sector infrastructure.
> @@ -189,6 +197,10 @@ int main(int argc, char **argv)
>  {
>      int ret;
>
> +    ret = boot_sector_init(disk);
> +    if(ret)
> +        return ret;

This needs braces and a space after "if".

thanks
-- PMM