|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v2 06/29] pcspk: use QEMU_ALIGN_DOWN |
Date: | Thu, 13 Jul 2017 22:29:15 -1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/13/2017 06:31 AM, Marc-André Lureau wrote:
- s->samples = (PCSPK_BUF_LEN * PIT_FREQ / m * m / (PIT_FREQ >> 1) + 1) >> 1; + s->samples = (QEMU_ALIGN_DOWN(PCSPK_BUF_LEN * PIT_FREQ, m) / (PIT_FREQ >> 1) + 1) >> 1;
Wow. Um. Two divisions? Irritatingly, "m" appears to be the only non-constant. This a true and correct conversion, so Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |