[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/8] error: Functions to report warnings and
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/8] error: Functions to report warnings and informational messages |
Date: |
Wed, 12 Jul 2017 09:57:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Alistair Francis <address@hidden> writes:
> Add warn_report(), warn_vreport() for reporting warnings, and
> info_report(), info_vreport() for informational messages.
>
> These are implemented them with a helper function factored out of
> error_vreport(), suitably generalized. This patch makes no changes
> to the output of the original error_report() function.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> ---
> v2:
> - Don't add *vreport() functions to checkpatch
> - Maintain original comments for the reporting functions
> - Don't change the error report output in this patch
> v1:
> - Don't expose the generic report and vreport() functions
> - Prefix error messages
> - Use vreport instead of qmsg_vreport()
> RFC V3:
> - Change the function and enum names to be more descriptive
> - Add wrapper functions for *_report() and *_vreport()
>
> include/qemu/error-report.h | 7 +++
> scripts/checkpatch.pl | 6 ++-
> util/qemu-error.c | 102
> +++++++++++++++++++++++++++++++++++++++++---
> 3 files changed, 109 insertions(+), 6 deletions(-)
[...]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 73efc927a9..60b1f320a1 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2535,7 +2535,11 @@ sub process {
> error_prepend|
> error_reportf_err|
> error_vreport|
> - error_report}x;
> + report_vreport|
Should be warn_vreport, oops. I can fix this on commit.
> + info_vreport|
> + error_report|
> + warn_report|
> + info_report}x;
>
> if ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) {
> ERROR("Error messages should not contain newlines\n" .
> $herecurr);
[...]
[Qemu-devel] [PATCH v3 3/8] Convert error_report() to warn_report(), Alistair Francis, 2017/07/11