[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/4] VT-d: some enhancements on iotlb
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/4] VT-d: some enhancements on iotlb |
Date: |
Wed, 12 Jul 2017 00:47:22 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/4] VT-d: some enhancements on iotlb
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0363bbd intel_iommu: implement mru list for iotlb
661bf52 intel_iommu: use access_flags for iotlb
a571ac1 intel_iommu: let iotlb size tunable
3d04c28 intel_iommu: fix VTD_PAGE_MASK
=== OUTPUT BEGIN ===
Checking PATCH 1/4: intel_iommu: fix VTD_PAGE_MASK...
ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: hw/i386/intel_iommu_internal.h:387:
+#define VTD_PAGE_MASK ~(VTD_PAGE_SIZE - 1)
total: 1 errors, 0 warnings, 16 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/4: intel_iommu: let iotlb size tunable...
Checking PATCH 3/4: intel_iommu: use access_flags for iotlb...
Checking PATCH 4/4: intel_iommu: implement mru list for iotlb...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden