Re: [Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note

[Eduardo Habkost]

On Tue, Jul 11, 2017 at 10:04:43PM +0200, Laszlo Ersek wrote:
[...]
> > +    lines = g_strsplit((char *)vmci, "\n", -1);
> > +    for (i = 0; lines[i]; i++) {
> > +        if (g_str_has_prefix(lines[i], "NUMBER(phys_base)=")) {
> > +            if (qemu_strtou64(lines[i] + 18, NULL, 16,
> > +                              &phys_base) < 0) {
> > +                error_report("warning: Failed to read NUMBER(phys_base)=");
[...]
> > +        } else if (size < note_head_size || size > MAX_VMCOREINFO_SIZE) {
> > +            error_report("warning: vmcoreinfo size is invalid: %" PRIu32, 
> > size);
[...]
> > +                error_report("warning: Invalid vmcoreinfo header");

You will probably want to change this to warn_report() once
Alistair's series is merged.

-- 
Eduardo