qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] xen-mapcache: Fix the bug when overlapping emul


From: no-reply
Subject: Re: [Qemu-devel] [PATCH] xen-mapcache: Fix the bug when overlapping emulated DMA operations may cause inconsistency in guest memory mappings
Date: Tue, 11 Jul 2017 06:57:34 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH] xen-mapcache: Fix the bug when overlapping 
emulated DMA operations may cause inconsistency in guest memory mappings
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b4b8ac0 xen-mapcache: Fix the bug when overlapping emulated DMA operations may 
cause inconsistency in guest memory mappings

=== OUTPUT BEGIN ===
Checking PATCH 1/1: xen-mapcache: Fix the bug when overlapping emulated DMA 
operations may cause inconsistency in guest memory mappings...
ERROR: else should follow close brace '}'
#168: FILE: hw/i386/xen/xen-mapcache.c:268:
+        }
+        else if (!entry->lock || !entry->vaddr_base) {

total: 1 errors, 0 warnings, 48 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]