|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn |
Date: | Tue, 11 Jul 2017 10:41:18 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 11/07/2017 10:39, Kevin Wolf wrote: > Can you just add a comment to this effect to qcow2/qed_do_open() then? Good point. >>> Or maybe the cleaner way would be bdrv_drained_begin/end() around >>> everything directly in bdrv_co_invalidate_cache(). > > Should we do this anyway? Or assert that no requests are in flight? I can certainly add assertions for clarity, but wouldn't requests have failed the permission checks and caused assertion failures already? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |