[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/22] tcg: enable per-thread TCG for softmmu
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 21/22] tcg: enable per-thread TCG for softmmu |
Date: |
Tue, 11 Jul 2017 10:02:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 11/07/2017 00:13, Emilio G. Cota wrote:
> On Mon, Jul 10, 2017 at 17:33:07 -0400, Paolo Bonzini wrote:
>>
>>> I agree that it would be nice to have the same mechanism for all.
>>>
>>> The main hurdle I see is how to allow for concurrent code generation while
>>> minimizing flushes of the single, fixed-size[*] code_gen_buffer.
>>> In user-mode this is tricky because there is no way to bound the number
>>> of threads that might be spawned by the guest code (I don't think reading
>>> /proc/sys/kernel/threads-max is a viable solution here).
>>>
>>> Switching to a "__thread *tcg_ctx_ptr" model will help minimize
>>> user-mode/softmmu differences though. The only remaining difference would be
>>> that user-mode would need tb_lock() around tb_gen_code, whereas softmmu
>>> wouldn't, but everything else would be the same.
>>
>> Hmm, tb_gen_code is already protected by mmap_lock in linux-user, so you
>> wouldn't
>> get any parallelism. On the other hand, you could just say that the
>> fixed-size
>> code_gen_buffer is protected by mmap_lock, which doesn't exist for softmmu.
>
> Yes. tb_lock/mmap_lock, or like they're called in some asserts, memory_lock.
>
> A way to get some parallelism in user-mode given the constraints
> would be to share regions among TCG threads. Threads would still need to take
> a per-region lock, but it wouldn't be a global lock so that would scale
> better.
>
> I'm not sure we really need that much parallelism for code generation in
> user-mode,
> though. So I wouldn't focus on this until seeing benchmarks that have a clear
> bottleneck due to "memory_lock".
I agree. Still, we could minimize the differences by protecting
tb_gen_code only with mmap_lock, instead of mmap_lock+tb_lock.
Paolo
[Qemu-devel] [PATCH 17/22] tcg: distribute profiling counters across TCGContext's, Emilio G. Cota, 2017/07/09
Re: [Qemu-devel] [PATCH 00/22] tcg: per-thread TCG, Emilio G. Cota, 2017/07/09
Re: [Qemu-devel] [PATCH 00/22] tcg: per-thread TCG, Alex Bennée, 2017/07/10