[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] 答复: Re: [PATCH] tcg/mips: reserve a register for the guest_
From: |
jiang.biao2 |
Subject: |
[Qemu-devel] 答复: Re: [PATCH] tcg/mips: reserve a register for the guest_base. |
Date: |
Tue, 11 Jul 2017 07:42:31 +0800 (CST) |
> On 07/09/2017 11:12 PM, Jiang Biao wrote:
> > Reserve a register for the guest_base using ppc code for reference.
> > By doing so, we do not have to recompute it for every memory load.
> >
> > Signed-off-by: Jiang Biao<address@hidden>
> > Signed-off-by: Richard Henderson<address@hidden>
> > ---
> > tcg/mips/tcg-target.inc.c | 17 +++++++++++++----
> > 1 file changed, 13 insertions(+), 4 deletions(-)
>
> For future reference, you should not add a Signed-off-by for someone else.
> That is like writing someone else's signature.
>
> You may acknowledge my suggestion with a Suggested-by tag.
>
> QEMU uses the same rules for this as does the linux kernel. Please read
>
> > https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst
>
> or at least section 11 from
>
>> https://github.com/torvalds/linux/blob/master/Documentation/translations/zh_CN/SubmittingPatches
> (The translation may be be out of date. I don't see any of the other tags,
> like Suggested-by, within the Chinese text.)
>
> That said, applied to tcg-next.
Got that:-). Thanks for your advice.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] 答复: Re: [PATCH] tcg/mips: reserve a register for the guest_base.,
jiang.biao2 <=